Fixed blank response header error #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krytenuk this looks great, thanks for submitting! I reworked it a little bit but let me know if that doesn't match with what you intended. I'm preparing a release soon and would love to get this fix included |
|
@bryannielsen I have pulled your improvements and they seem to be working a treat. All fine on my local and working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue when Coilpack processes the response headers.
The headers are split into an array with explode. If the header is blank, just contains the
header-name:then the response will attempt to access the value, array key 1, resulting in undefined array key error as it does not exist. Also the blank header name, array key 0, still has the original header names colon suffixed.I simply removed the trailing colon from the name and set array key 1 to an empty string when the header array does not contain two elements.